New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in DekuContainerRead::from_reader docs #516

Merged

wcampbell0x2a merged 1 commit into master from 504-fix-from-reader-docs

Jan 19, 2025

Collaborator

wcampbell0x2a commented Jan 18, 2025

Closes #504


          Fix bug in DekuContainerRead::from_reader docs

dd36c37

Closes #504

github-actions bot commented Jan 18, 2025

Benchmark for `89e02cd`

Click to view benchmark

Test	Base	PR	%
count_from_u8_specialize	96.2±0.89ns	90.3±0.56ns	-6.13%
count_no_specialize	2.4±0.03µs	2.4±0.03µs	0.00%
count_specialize	97.1±1.17ns	97.1±0.87ns	0.00%
deku_read_bits	1209.0±14.02ns	1195.1±45.64ns	-1.15%
deku_read_byte	4.7±0.13ns	5.8±0.19ns	+23.40%
deku_read_enum	3.8±0.06ns	4.8±0.03ns	+26.32%
deku_read_vec	30.0±0.45ns	30.0±0.43ns	0.00%
deku_write_bits	210.4±5.31ns	210.3±3.47ns	-0.05%
deku_write_byte	23.4±0.20ns	23.4±0.33ns	0.00%
deku_write_enum	22.2±0.34ns	22.1±0.33ns	-0.45%
deku_write_vec	497.6±6.19ns	506.8±11.24ns	+1.85%
read_all	4.1±0.06µs	5.1±0.07µs	+24.39%
read_all_bytes	4.2±0.05µs	5.1±0.15µs	+21.43%

sharksforarms approved these changes

View reviewed changes

Owner

sharksforarms left a comment

LGTM

wcampbell0x2a merged commit 7b09220 into master

15 checks passed

wcampbell0x2a deleted the 504-fix-from-reader-docs branch

January 19, 2025 03:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet