Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented colorblindness simulations #80

Merged
merged 5 commits into from
Sep 1, 2019

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Aug 29, 2019

I wrote an XYZ <-> LMS conversion so that the protanopia, deteranopia, and tritanopia filters can be applied in the LMS space and then converted back to whatever.

Usage example:

pastel color a3247b | pastel colorblind deut

Issue: The output doesn't exactly match what I see with Color Oracle, but it's pretty close.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this is really great 🥇. Thank you very much for your contribution!

I like the idea, the CLI design and the implementation 😄 I only added a few minor inline comments.

src/cli/cli.rs Outdated Show resolved Hide resolved
src/cli/cli.rs Outdated Show resolved Hide resolved
src/cli/commands/color_commands.rs Outdated Show resolved Hide resolved
…ntation better; changed abbrviations for colorblindness types
@rozbb
Copy link
Contributor Author

rozbb commented Sep 1, 2019

Changes made. LMK if you see anything else that needs fixing

@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2019

Thank you very much! The updates look great.

@sharkdp sharkdp merged commit 1b401d9 into sharkdp:master Sep 1, 2019
@sharkdp
Copy link
Owner

sharkdp commented Sep 19, 2019

Released in v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants