Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to --pretty-print=never for -e and stdin input #240

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Default to --pretty-print=never for -e and stdin input #240

merged 1 commit into from
Nov 10, 2023

Conversation

0xAdk
Copy link
Contributor

@0xAdk 0xAdk commented Nov 9, 2023

see #237

Pretty sure this is a breaking change since I added a parameter to InterpreterResult::to_markup()

@sharkdp
Copy link
Owner

sharkdp commented Nov 9, 2023

Thank you very much for your contribution!

This looks great. I just merged #97. It would be great if you could rebase your branch. Let me know if you need help resolving the conflicts.

@sharkdp
Copy link
Owner

sharkdp commented Nov 9, 2023

Pretty sure this is a breaking change since I added a parameter to InterpreterResult::to_markup()

I don't think the numbat crate has any users (yet). I also didn't really design it as a proper "public" library so far. But thank you for taking that into consideration!

@0xAdk
Copy link
Contributor Author

0xAdk commented Nov 10, 2023

ok it's rebased, I also went ahead and changed https://github.com/sharkdp/numbat/pull/240/files#diff-723b19ccffb6afcf74a982f6dd78c112191d462e58d360c9fa49167157b1d278R136 if you don't mind.

sharkdp
sharkdp reviewed Nov 10, 2023
View reviewed changes
numbat-cli/src/main.rs
Comment on lines +136 to +137
config.main.load_prelude &= !args.no_prelude;
config.main.load_user_init &= !(args.no_prelude || args.no_init);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I knew there was a better way to write this, I was just too lazy to think yesterday 😄

@sharkdp sharkdp merged commit 94a11a2 into sharkdp:master Nov 10, 2023
@sharkdp
Copy link
Owner

sharkdp commented Nov 10, 2023

Thank you very much!

@p-linnane p-linnane mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xAdk @sharkdp