-
-
Notifications
You must be signed in to change notification settings - Fork 127
Not arbitrary precision. Floating point range. Lower expectations please. #108
Comments
The internal precision is greater than what you see in your first example:
It's only the output that's currently restricted to six significant digits (see also #107), as this is more than enough for most real-world applications (in my opinion). insect depends on purscript-quantities, which depends on purescript-decimals, which internally uses decimal.js. The README says that insect uses an arbitrary-precision numeric type because that's what decimal.js advertises. I believe this is only true in the sense that the precision is limited to N significant digits, where N can be configured. For insect, currently, we have N set to 30. But this could be changed (or made configurable: #107). |
I would still very clearly lower expectations. Not sure what you mean by "internal precision", but I made the tool output a bunch of zeroes that really shouldn't be here in the first place. I can understand truncation, but are you saying that you are showing wrong digits on purpose? Nothing in the README warns users that the model leads to errors like the examples I gave, and "arbitrary-precision numeric type" definitely led me to the wrong conclusion. (BTW great tool, I'm already using it a lot) |
Showing
Okay, what do you think: "Uses a high-precision numeric type with 30 significant digits that handles very large (or small) exponents like 10^(10^10)."
Thanks! I'm glad you like it. |
If I cannot get more digits of π or get 1 back this isn't arbitrary precision at all.
Please adjust your README:
The text was updated successfully, but these errors were encountered: