Enable link-time optimization in release builds #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release builds, it's probably worth enabling link-time optimization (LTO). The performance gains can be moderately significant: In the
warm-cache-simple-pattern
benchmark I observed an 8% improvement in the case of the[0-9]\.jpg$
pattern, and an 11% improvement in the case of the.*[0-9]\.jpg$
pattern. (Of course, much like the example benchmark in the README, this is one particular benchmark on one particular machine. I do wish there was a standardized set of files to run the benchmarks against, as I see was discussed (but not resolved) in issue #36.)The main downside of LTO is that it makes the compile times longer. I feel that it's worth making that tradeoff in a tool like
fd
, for which (runtime) speed is one of its major selling points.