Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when try to read a block device #3128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Integral-Tech
Copy link

@Integral-Tech Integral-Tech commented Nov 20, 2024

  • When reading a block device using bat, an error should be thrown.

@Integral-Tech
Copy link
Author

@sharkdp

@keith-hall
Copy link
Collaborator

Does POSIX cat also error out when trying to read a block device? The aim is to maintain compatibility to be a drop in replacement. Also, an integration would be nice if we are to consider merging this :)

@Integral-Tech
Copy link
Author

Integral-Tech commented Nov 25, 2024

Does POSIX cat also error out when trying to read a block device? The aim is to maintain compatibility to be a drop in replacement. Also, an integration would be nice if we are to consider merging this :)

No, but use bat to read a block device will make it stuck (have to force terminate with Ctrl+C)

@keith-hall
Copy link
Collaborator

I wonder if there is a better solution that doesn't involve disabling functionality like #3101 or #2902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants