Fix #182 #185
Merged
Fix #182 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
Jul 5, 2018
src/printer.rs
Outdated
| for chunk in ansi_iterator { | ||
| match chunk { | ||
| // ANSI escape passthrough. | ||
| (text, true) => { | ||
| ansi_prefix = text; | ||
| if text.chars().last().unwrap() == 'm' { |
There was a problem hiding this comment.
Can we prevent the usage of unwrap() here? Maybe by using .map_or(false, |c| c == 'm')?
|
I used your suggested change, and I added a little extra logic to clear the |
|
Sorry for the late reply.. I'm happy to merge this once the style changes are fixed (I tried to get an up-to-date rustfmt version to fix it myself, but couldn't get it to work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
Results (italic = yellow):
cat foo bar baz
bat 0.4.1: foo bar baz
fix-182: foo bar baz