Avoid DB connections during assets:precompile #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolaracco Thanks! I tried this locally and indeed, it fixes the issue with the MySQL connection when compiling assets. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unable to compile the assets when building a docker image because the
assets:precompiletask attempts to establish a connection to the database. The problem is related to the initializer of money-rails 1.3.0 that invokingActiveRecord::Base.connectiontriggers a new connection to the database.Since the 1.4.0, this bug has been fixed in money-rails (see the new initializer). It seems there are no regressions in the test suite, and the
assets:precompiletask is now running fine.Given I'm still not confident with the codebase I didn't dare to update money-rails to the latest version (1.7.0).