Transactions #163
Draft
Transactions #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62915a5.
alecgibson
commented
Jan 21, 2025
| // we have two different transactions attempting to update the same collection. | ||
| // Here, we manually keep track of the collections involved in transactions, so that | ||
| // we can avoid this deadlock. | ||
| var isLocked = this._lockedCollections[collectionName] && |
There was a problem hiding this comment.
As I mentioned in share/sharedb#689 (comment) this locking complexity may be removed entirely if we follow MongoDB's own behaviour and define cross-transactional, awaited writes to the same document to be undefined behaviour. Instead, if we just let them run in parallel, MongoDB and ShareDB can do their thing.
| // Here, we manually keep track of the collections involved in transactions, so that | ||
| // we can avoid this deadlock. | ||
| var isLocked = this._lockedCollections[collectionName] && | ||
| this._lockedCollections[collectionName] !== options.transaction; |
There was a problem hiding this comment.
NB: if we keep this behaviour (I don't think we should), I think MongoDB locks on a document level, so we should update this key to collectionName + id to avoid unnecessary locking.
| // current transaction | ||
| // TODO: Wait for this? | ||
| this.abortTransaction(this._lockedCollections[collectionName], function(error) { | ||
| // TODO: Handle errors |
There was a problem hiding this comment.
I'm not really sure what to do with this error, and this feels like a bit of a code smell in the architecture of transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.