tv-casting-app: Increasing EMBER_BINDING_TABLE_SIZE from 10 to 64 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
sharadb-amazon
force-pushed
the
v1.0.0-branch-binding-size
branch
from
b319866 to
ea69ffd
Compare
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
chrisdecenzo
approved these changes
Jan 19, 2024
cliffamzn
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the tv-casting-app is commissioned by many Matter TVs, it seems it can run out of space in the Binding table that is cached on disk. This leads to issues during commissioning where the app does not find a nodeId corresponding to a fabricIndex because the binding table overflowed.
Change summary
Increased EMBER_BINDING_TABLE_SIZE from 10 to 64
Testing
Built and tested with the iOS tv-casting-app against the Linux tv-app