tv-casting-app: allowing up to 20 ACL entries #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
cliffamzn
approved these changes
Oct 4, 2023
sharadb-amazon
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For casting, we need to allow more ACL entries, and more complex entries.
For example, the CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_ENTRIES_PER_FABRIC defaults to 4 as a result of which commissioning fails with a "Resource Exhausted" error when that limit is reached.
These limits were already set to 20 for the tv-app with an old PR: https://github.com/project-chip/connectedhomeip/pull/15468/files#diff-b71768c25b60bcee1ada91524bd579cb5a870b8c3899aa2e4235fa17fb3de7f9 but not the tv-casting-app.
This PR brings this limit up to 20 for the tv-casting-app as well.
Testing
Built and tested tv-casting-app against the tv-app to ensure commissioning succeeds.