android/tv-casting-app: Adding ConfigurationManager as AppParameter #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
requested review from
rawadhilal88,
cliffamzn and
domichae-amazon
...app/android/App/app/src/main/java/com/chip/casting/util/PreferencesConfigurationManager.java
Outdated
Show resolved
Hide resolved
...app/android/App/app/src/main/java/com/chip/casting/util/PreferencesConfigurationManager.java
Outdated
Show resolved
Hide resolved
sharadb-amazon
force-pushed
the
v1.0.0-branch-config
branch
from
bb837d7 to
db3083c
Compare
domichae-amazon
approved these changes
Mar 31, 2023
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
3 similar comments
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
sharadb-amazon
added a commit
that referenced
this pull request
Apr 4, 2023
sharadb-amazon
added a commit
that referenced
this pull request
Apr 5, 2023
sharadb-amazon
added a commit
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Android TV Casting library does not allow the tv-casting client app to pass in its own version of the ConfigurationManager.
Change summary
Testing
Tested that commissioning works when running an Android tv-casting-app against a Linux tv-app