Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffamzn
reviewed
Feb 27, 2023
examples/tv-casting-app/android/App/app/src/main/jni/com/chip/casting/DiscoveredNodeData.java
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/com/chip/casting/DiscoveredNodeData.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/com/chip/casting/DiscoveredNodeData.java
Show resolved
Hide resolved
sharadb-amazon
force-pushed
the
v1.0.0-branch-def
branch
from
de0e3c8 to
9212848
Compare
cliffamzn
approved these changes
Feb 27, 2023
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
2 similar comments
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
|
All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id> |
sharadb-amazon
added a commit
that referenced
this pull request
Mar 3, 2023
… constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
sharadb-amazon
added a commit
that referenced
this pull request
Mar 9, 2023
… constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
sharadb-amazon
added a commit
that referenced
this pull request
Mar 9, 2023
… constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
sharadb-amazon
added a commit
that referenced
this pull request
Mar 9, 2023
…arsing (project-chip#25464) * Checking if multicastLock isHeld before trying to release it, avoiding stopServiceDiscovery call if discovery failed to start * Android tv-casting-app: Adding defensive checks in DiscoveredNodeData constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
sharadb-amazon
added a commit
that referenced
this pull request
Mar 17, 2023
… constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
sharadb-amazon
added a commit
that referenced
this pull request
Mar 17, 2023
… constructor (#108) * Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor * Adding more defensive checks / exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Adding defensive null checks on serviceInfo.attributes returned by the NsdManager before dereferencing them
Testing
Tested with the Android tv-casting-app running against the Linux tv-app