Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address testing feedback from opcert callbacks, and re-commissioning (p…
Browse files Browse the repository at this point in the history
…roject-chip#22369)

* Draft: address testing feedback from new opcert callbacks

* temporary workaround to isolate a memory corruption

* add check for existing fabric during commissioning, handle correctly on content app platform

* address comments

* address comments

* address comments

* Restyled by clang-format (project-chip#22524)

Co-authored-by: Restyled.io <[email protected]>

* address comments

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
3 people authored and sharadb-amazon committed Dec 21, 2022
1 parent 61eca2a commit c5ef2ba
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/platform/linux/CommissionerMain.h
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ using chip::Transport::PeerAddress;
CHIP_ERROR CommissionerPairOnNetwork(uint32_t pincode, uint16_t disc, PeerAddress address);
CHIP_ERROR CommissionerPairUDC(uint32_t pincode, size_t index);

CHIP_ERROR InitCommissioner(uint16_t commissionerPort, uint16_t udcListenPort, chip::FabricId fabricId = chip::kUndefinedFabricId);
CHIP_ERROR InitCommissioner(uint16_t commissionerPort, uint16_t udcListenPort, chip::FabricId fabricId);
void ShutdownCommissioner();

DeviceCommissioner * GetDeviceCommissioner();
2 changes: 1 addition & 1 deletion src/controller/CHIPDeviceController.cpp
Original file line number Diff line number Diff line change
@@ -2061,7 +2061,7 @@ void DeviceCommissioner::PerformCommissioningStep(DeviceProxy * proxy, Commissio
app::InteractionModelEngine * engine = app::InteractionModelEngine::GetInstance();
app::ReadPrepareParams readParams(proxy->GetSecureSession().Value());

// NOTE: this array cannot have more than 9 entries, since the spec mandates that server only needs to support 9
// NOTE: this array cannot have more than 9 entries, since 9 is what the spec requires as a minimum on servers
app::AttributePathParams readPaths[9];
// Read all the feature maps for all the networking clusters on any endpoint to determine what is supported
readPaths[0] = app::AttributePathParams(app::Clusters::NetworkCommissioning::Id,

0 comments on commit c5ef2ba

Please sign in to comment.