Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add eslint #453

Closed
wants to merge 23 commits into from
Closed

Conversation

NeOMakinG
Copy link
Contributor

@NeOMakinG NeOMakinG commented Mar 9, 2022

Informations

This PR introduces ESLint in the hdwallet repository.

As the project has a lot of legacy, we decided to ignore a lot of errors that could be fixed later or while refactoring.

Most of ignored are scoped the the rule failing, so it permits to detect some others problems.

Closes #353

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/2BSKpwVsQZduEXEru1NbGCm2X51H
✅ Preview: https://hdwallet-git-fork-neomaking-add-eslint-shapeshift.vercel.app

This reverts commit b5f9d25.
@NeOMakinG
Copy link
Contributor Author

Closing in favor of #485

@NeOMakinG NeOMakinG closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add/enforce eslint typescript warnings
2 participants