native: make isolation engines work with structuredClone() #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/GHX5KDH8y62n9hTabHsPJJhy2oCH |
mrnerdhair
changed the title
mrnerdhair
force-pushed
the
improve-isolation-interface-2
branch
from
03f744a to
4c0bba0
Compare
mrnerdhair
changed the title
mrnerdhair
force-pushed
the
improve-isolation-interface-2
branch
from
4c0bba0 to
532b8c5
Compare
mrnerdhair
force-pushed
the
improve-isolation-interface-2
branch
from
532b8c5 to
5b0d01d
Compare
mrnerdhair
changed the title
pastaghost
approved these changes
Nov 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #366.
One type of implementation for isolation engines that we'd like to support is a scheme where parameters are passed between origins or workers using e.g.
window.postMessage(). The current interface doesn't make this straightforward, because themessageparameter forecdsaSign()has itspreimageandalgorithmfields stripped by the structured clone algorithm in the process. To avoid having to work around this issue with some kind of wrapper or adapter, this PR changes the isolation engine interface so that all its parameters are structured-clone compatible.Likewise, the
recoveryParamvalue attached toRecoverableSignatures returned byecdsaSignis stripped by structured cloning. This PR changes that type to anethers.Signature-style 65-byte array, where the last byte is the recovery parameter, rather than a 64-byte array with an extrarecoveryParamproperty.