Card Voew for projects #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanushka
requested changes
Jul 20, 2020
| import '../donut-chart/donut-chart'; | ||
|
|
||
| import { AVATAR, HOUR, COMMENT } from '../../constants/imagepath'; | ||
| import { nothing } from 'lit-html'; |
| font-weight: 500; | ||
| font-size: 14px; | ||
| line-height: 18px; | ||
| color: #757575; |
| } | ||
|
|
||
| paper-card { | ||
| padding: 12px; |
| } | ||
|
|
||
| .dark-green { | ||
| color: #4CAF50; |
| /** | ||
| * Function to run when clicked on profile. | ||
| */ | ||
| profileClicked: { type: Function }, |
| <div class="field">Started Date: <span class="field-value">${this.startedDate}</span></div> | ||
| <div class="field">Due Date: <span class="field-value">${this.dueDate}</span></div> | ||
| </div> | ||
| <div class="percent-indicator small"><span class="percentage ${this.indicatorColor}">${this.progressValue}%</span></div> |
| <img src=${COMMENT} alt="comment"> | ||
| </mwc-icon-button> | ||
| </div> | ||
| <div @click=${this.profileClicked} class="picture"> |
There was a problem hiding this comment.
use @click in button or keep a tag instead
|
|
||
|
|
||
|
|
||
| window.customElements.define('card-view-view', CardViewView); |
There was a problem hiding this comment.
change the custom element name
| /** | ||
| * Funtion to run when more icon is clicked. | ||
| */ | ||
| moreIconClicked: {type: Function} |
There was a problem hiding this comment.
onMoreIconClick . Use on as prefix in these type of functions
| connectedCallback() { | ||
| super.connectedCallback(); | ||
|
|
||
| this.options = { |
There was a problem hiding this comment.
why is the option being set in connectedCallBack?
shanushka
requested changes
Jul 20, 2020
| this.picture = AVATAR; | ||
| this.progressValue = 80; | ||
| this.progressColor = 'green'; | ||
| this.dueDate = '2020-20-20'; |
There was a problem hiding this comment.
use a single object card to represent these variables of card data
| ${this.title} | ||
| </div> | ||
| <div> | ||
| <paper-icon-button icon="icons:more-vert" class="more-icon" @click="${this.moreIconClicked}"></paper-icon-button> |
shresthasamir4119
force-pushed
the
card-view
branch
from
4310bb7 to
3353db3
Compare
shresthasamir4119
force-pushed
the
card-view
branch
from
3353db3 to
5aae98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining :
can be resized by external div