Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable controls #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maxisandoval37
Copy link

No description provided.

@shanet
Copy link
Owner

shanet commented Nov 17, 2024

Hi Maxi, can you add some details on the background for this? I left the controls attribute off initially because in my testing pausing/resuming a plain WebRTC stream would cause it to freeze making the controls useless at best and harmful at worst. Is there a strong reason to add them here that would make this demo easier to use?

@maxisandoval37
Copy link
Author

maxisandoval37 commented Nov 17, 2024 via email

@shanet
Copy link
Owner

shanet commented Nov 18, 2024

Hmm, I'd be interested in knowing why it did not start the video when the connection was established in that case. Are there any errors in the console? Do you have anything in your browser that prevents videos from autoplaying? Any extensions perhaps? Which browser/version/OS are you using and is the behavior consistently reproducible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants