Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value Displays and Editors should always have and receive parent container instead of injecting the editor into the HTML #436

Open
shamansir opened this issue Feb 16, 2017 · 2 comments

Comments

@shamansir
Copy link
Owner

shamansir commented Feb 16, 2017

From #417 and #434

@shamansir
Copy link
Owner Author

It is resolved for SVG styles, but fails for most of the HTML styles, so probably it should be fixed in the styles, not in the renderer (since they create the HTML element to hold the value).

@shamansir
Copy link
Owner Author

No, the problem is actually different:

  • There's always a .value-holder for inlets, a wrapper for a .value, since they need a parent element where editor needs to be injected;
  • There's no .value-holder for outlets, since they need no editor;
  • channelrenderer.show should work for both cases;
  • Channel Renderers currently inject value directly into the element using innerHtml for both cases;

shamansir added a commit that referenced this issue Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant