windows partial support #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this discussion
Sorry for waiting so long, it took me more time than I exptected.
You're right about PATH, unfortunately, I don't see any decent solution right now.
To add proper paths and environment variables for running emscripten, You need run emsdk_env.bat from emsdk directory.
However, this script sets path to nodejs directory inside emsdk directory. Because nodejs from esdk is in version 4.1.1, ES6 features from wasm-init package will not work..
Solution which I propose for now, is running
emsdk activatecommand with--globalflag, and then remove emsdk nodejs path from environment variables. It should work with this PR.If I will have more time, I will try to automate those tasks.