Merge pull request #35 from lukeburns/master

unload only if not mounted
shama · Aug 10, 2018 · cec46f1 · cec46f1
2 parents 932684e + d4d2ccd
commit cec46f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -15,8 +15,12 @@ if (window && window.MutationObserver) {
         eachAttr(mutations[i], turnon, turnoff)
         continue
       }
-      eachMutation(mutations[i].removedNodes, turnoff)
-      eachMutation(mutations[i].addedNodes, turnon)
+      eachMutation(mutations[i].removedNodes, function (index, el) {
+        if (!document.documentElement.contains(el)) turnoff(index, el)
+      })
+      eachMutation(mutations[i].addedNodes, function (index, el) {
+        if (document.documentElement.contains(el)) turnon(index, el)
+      })
     }
   })
   if (document.body) {

diff --git a/test.js b/test.js
@@ -8,13 +8,13 @@ test('onload/onunload', function (t) {
   el.textContent = 'test'
   onload(el, function () {
     t.ok(true, 'onload called')
+    document.body.removeChild(el)
   }, function () {
     t.ok(true, 'onunload called')
     document.body.innerHTML = ''
     t.end()
   })
   document.body.appendChild(el)
-  document.body.removeChild(el)
 })
 
 test('assign key attr', function (t) {
@@ -66,13 +66,13 @@ test('nested', function (t) {
   var e3 = document.createElement('div')
   onload(e3, function () {
     t.ok(true, 'onload called')
+    e2.removeChild(e3)
   }, function () {
     t.ok(true, 'onunload called')
     document.body.innerHTML = ''
     t.end()
   })
   e2.appendChild(e3)
-  e2.removeChild(e3)
 })
 
 test('complex', function (t) {