Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't recommend deprecated https config option #380

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: don't recommend deprecated https config option #380

merged 1 commit into from
Nov 23, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 17, 2023

Summary

https: true has been deprecated in favor of server: 'https'

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Copy link
Contributor

@ahangarha ahangarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏾

We implemented support for the latest webpack dev server config but this message was left out of the PR.

@ahangarha
Copy link
Contributor

From the CI failure:

error This project's package.json defines "packageManager": "[email protected]". However the current global version of Yarn is 1.22.21.

@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 17, 2023

Yeah Yarn v1.22.20 introduced that "message" though it doesn't explicitly say it'll fail, and v1.22.21 has an env variable that can be set to skip it - I'm looking into this around other CI failures happening related to seg faults in the browser tests; it also doesn't happen on all PRs because for some reason some job runs end up with Yarn v1.22.19 instead

@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 17, 2023

fwiw too ackama/rails-template#466 doesn't seem to be having any trouble with this and it's definitely using v1.22.21 so currently I'm not worried this is a general failure that will interfere when using package_json with modern versions of stuff

@justin808 justin808 merged commit a954000 into shakacode:master Nov 23, 2023
40 of 41 checks passed
@G-Rath G-Rath deleted the fix-error-message branch November 23, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants