Change NODE_ENV defaults #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: updated CHANGELOG
alexeyr-ci1
reviewed
Sep 6, 2022
README.md
Outdated
| @@ -350,6 +350,7 @@ Note, if you are using server-side rendering of JavaScript with dynamic code-spl | |||
| ### Development | |||
|
|
|||
| Webpacker ships with two binstubs: `./bin/webpacker` and `./bin/webpacker-dev-server`. Both are thin wrappers around the standard `webpack.js` and `webpack-dev-server.js` executables to ensure that the right configuration files and environmental variables are loaded based on your environment. | |||
| The setting of the NODE_ENV should be removed from the binstubs. | |||
There was a problem hiding this comment.
This should go to the changelog, not here.
There was a problem hiding this comment.
This should go to the changelog, not here.
I added it to the changelog also https://github.com/shakacode/shakapacker/pull/185/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR10
and I think we should keep this line or move it somewhere else because the old binstubs will still have the old NODE_ENV defaults if a new install isn't done.
There was a problem hiding this comment.
Please change, @mage1711:
Older Shakapacker installations had the setting of a missing NODE_ENV in the binstubs as the default per RAILS_ENV is no longer set there.
justin808
requested changes
Sep 7, 2022
README.md
Outdated
| @@ -350,6 +350,7 @@ Note, if you are using server-side rendering of JavaScript with dynamic code-spl | |||
| ### Development | |||
|
|
|||
| Webpacker ships with two binstubs: `./bin/webpacker` and `./bin/webpacker-dev-server`. Both are thin wrappers around the standard `webpack.js` and `webpack-dev-server.js` executables to ensure that the right configuration files and environmental variables are loaded based on your environment. | |||
| The setting of the NODE_ENV should be removed from the binstubs. | |||
There was a problem hiding this comment.
Please change, @mage1711:
Older Shakapacker installations had the setting of a missing NODE_ENV in the binstubs as the default per RAILS_ENV is no longer set there.
justin808
deleted the
183-node_env-needs-to-default-to-development-if-not-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed NODE_ENV defaults from
to