Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low latency dash support staging #88

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix to pass LL-DASH testcase: update dashStreamsReady() fn to account…
… for LL-DASH MPD
  • Loading branch information
CaitlinOCallaghan committed Aug 15, 2021
commit 19b9b8c6dfcf86b3031da404f8de71750d6d7616
14 changes: 11 additions & 3 deletions run_end_to_end_tests.py
Original file line number Diff line number Diff line change
@@ -91,9 +91,17 @@ def dashStreamsReady(manifest_path):
pattern = re.compile(r'<Representation.*?((\n).*?)*?Representation>')
with open(manifest_path) as manifest_file:
for representation in pattern.finditer(manifest_file.read()):
if not re.search(r'<S t', representation.group()):
# This Representation has no segments.
return False
if controller.is_low_latency_dash():
# LL-DASH manifests do not contain the segment reference tag <S>.
# Check for the availabilityTimeOffset attribute instead.
if not re.search(r'availabilityTimeOffset', representation.group()):
# This Representation does not have a availabilityTimeOffset yet,
# meaning the first chunk is not yet ready for playout.
return False
else:
if not re.search(r'<S t', representation.group()):
# This Representation has no segments.
return False

return True

8 changes: 8 additions & 0 deletions streamer/controller_node.py
Original file line number Diff line number Diff line change
@@ -300,6 +300,14 @@ def is_vod(self) -> bool:

return self._pipeline_config.streaming_mode == StreamingMode.VOD

def is_low_latency_dash(self) -> bool:
"""Returns True if the pipeline is running in LL-DASH mode.

:rtype: bool
"""

return self._pipeline_config.is_low_latency_dash

class VersionError(Exception):
"""A version error for one of Shaka Streamer's external dependencies.