Add support for HEVC video codec #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
Jun 7, 2021
This reverts commit 98da2f5.
|
Heh sorry about that :) Extra changes reverted |
joeyparrish
requested changes
Jun 7, 2021
|
@joeyparrish I think with the way the tests are constructed right now (using shaka player to stream the output in a browser instance), any test I add will more than likely fail due to general lack of browser support for this codec |
|
You're right about that. But I believe I have a way to structure the test so that we can at least prove that encoding succeeded and that the correct codec string appears in the manifest. |
|
I'll go ahead and merge this, then follow-up with a change to add the missing test. I'll link to it here FYI. Thanks! |
joeyparrish
approved these changes
Jun 8, 2021
shaka-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
We no longer have to rely on browser support for a codec to check Streamer support for a codec. We can check the manifest right after parsing, and ignore any playback errors. This also adds a test case for PR #74 (HEVC support) which was too difficult to add before this refactor. Change-Id: I37edb8ff7c94134e74e7a86f85c5b44bf4b38e24
|
I've added a test for HEVC and a structure for future codec tests, without depending on browser support for any given codec: 89254b4 Thanks again for contributing! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using same FFmpeg parameters as h264 for the most part but letting the encoder choose profile and level automatically.
Bitrate settings mirror vp9
tested on macOS 10.15.7 and Ubuntu 20.04 LTS (FFmpeg 4.4)