Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix mypy linter errors and warnings #226

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

joeyparrish
Copy link
Member

A newer linter complains about our codec enums:

streamer/bitrate_configuration.py:40: error: Enum members must be left unannotated [misc]
streamer/bitrate_configuration.py:40: note: See https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members

And also this shows up in Python 3.12:

streamer/periodconcat_node.py:128: SyntaxWarning: invalid escape sequence '{'
namespace_matches = re.search('{([^}]*)}', concat_mpd.tag)

A newer linter complains about our codec enums:

> streamer/bitrate_configuration.py:40: error: Enum members must be left unannotated  [misc]
> streamer/bitrate_configuration.py:40: note: See https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members

And also this shows up in Python 3.12:

> streamer/periodconcat_node.py:128: SyntaxWarning: invalid escape sequence '\{'
>  namespace_matches = re.search('\{([^}]*)\}', concat_mpd.tag)
@joeyparrish joeyparrish requested a review from a team January 15, 2025 04:26
@joeyparrish joeyparrish mentioned this pull request Jan 15, 2025
@joeyparrish joeyparrish merged commit 3e78b77 into shaka-project:main Jan 15, 2025
16 checks passed
@joeyparrish joeyparrish deleted the fix-linter branch January 15, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants