fix(cloud): Retry on all failures #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses basic retry settings for GCS and S3. If we do not pass these params, GCS would normally only retry if certain params were passed to convince it that the operation was idempotent. We know our use case, so we know we can safely retry. There will never be two versions of the same segment file, or two concurrent writes to the MPD, for example.
|
Still verifying this fix. It takes a long time for these failures to show up, but they were being treated as fatal before. |
|
This appears to be working. I hadn't made it past 6 hours with the previous revision, and we just reached 7.5 without errors with this one. |
|
This is definitely working. In combination with some other changes, also in Packager, I've made it through several loops in my live stream now without errors. It has been running for the last 13.5 hours. I think with this, we have the most stable and performant cloud upload feature we've ever had. |
mariocynicys
approved these changes
Oct 25, 2024
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses basic retry settings for GCS and S3.
If we do not pass these params, GCS would normally only retry if certain params were passed so that it knew the operation was definitely idempotent. We know our use case, so we know we can safely retry.
There will never be two versions of the same segment file, or two concurrent writes to the MPD, for example. So both uploads and deletes can be safely retried.