Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orphaned subprocesses after shutting down with CTRL+C #46

Closed
joeyparrish opened this issue Jan 16, 2020 · 0 comments · Fixed by #96
Closed

Orphaned subprocesses after shutting down with CTRL+C #46

joeyparrish opened this issue Jan 16, 2020 · 0 comments · Fixed by #96
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.0

Comments

@joeyparrish
Copy link
Member

Using the latest source from master, I find that shutting down the Shaka Player History live stream with CTRL+C causes our external command input (gource) and gsutil both to be orphaned instead of shut down properly.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 16, 2020
@joeyparrish joeyparrish added this to the v1.0 milestone Jan 16, 2020
@mariocynicys mariocynicys mentioned this issue Sep 20, 2021
Merged
joeyparrish pushed a commit that referenced this issue Sep 20, 2021
@mariocynicys
fix(external command): Create the new shell process in a new group (#96)
19e8652 
This PR launches the spawned shell in a new group so that we can just kill the group all together when stop is called.

Also:
 - Allows binary package to be built from any directory
 - Adds mono to the default channel configs available

Fixes #46
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 19, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fix(external command): Create the new shell process in a new group mariocynicys/shaka-streamer
2 participants
@joeyparrish @shaka-bot