Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log configs #225

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

joeyparrish
Copy link
Member

Log simplified versions of the config files to stderr. May be useful in services, to look at logs later to understand when configs changed, and how they may have impacted performance.

@joeyparrish joeyparrish requested a review from a team January 15, 2025 04:15
@joeyparrish
Copy link
Member Author

Linter errors fixed by #226. Converting this to draft until that is merged.

@joeyparrish joeyparrish marked this pull request as draft January 15, 2025 04:27
Log simplified versions of the config files to stderr. May be useful in services, to look at logs later to understand when configs changed, and how they may have impacted performance.
@joeyparrish joeyparrish marked this pull request as ready for review January 15, 2025 16:37
@joeyparrish
Copy link
Member Author

Rebased and ready.

@joeyparrish joeyparrish merged commit c2244c0 into shaka-project:main Jan 15, 2025
16 checks passed
@joeyparrish joeyparrish deleted the log-configs branch January 15, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants