Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write comprehensive docs for config file format and options #22

Closed
joeyparrish opened this issue Oct 7, 2019 · 0 comments
Closed

Write comprehensive docs for config file format and options #22

joeyparrish opened this issue Oct 7, 2019 · 0 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Milestone

Comments

@joeyparrish
Copy link
Member

Currently, we only have examples in config files. There should be comprehensive docs instead. If these can't be generated from the source, then we will have to maintain them separately.

@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Oct 7, 2019
@shaka-bot shaka-bot added this to the v1.0 milestone Oct 7, 2019
@joeyparrish joeyparrish self-assigned this Oct 10, 2019
shaka-bot pushed a commit that referenced this issue Oct 11, 2019
The config parsing and validation system has been rewritten.  The new
system correctly supplies default values for each field and is
self-documenting.  Although the per-field docstrings are not attached
to the fields by Python, they can be understood by a documentation
generator.

Each config structure is now represented by a class.  Fields with a
specific set of valid values are represented by an enum.  Float fields
will accept ints, and all other types are validated.  Object types are
constructed from sub-dictionaries, and will validate their own fields
recursively.  Defaults and required fields are attributes where the
field is defined, making them easy to find and change.

There is still more room for improvement, but adding new fields and
documenting them is now very easy to do.

This also flattens out the pipeline config, removing the transcoder
and packager sub-keys.

Tests and sample configs have been simplified to remove unnecessary
fields.  The test runner will now send config errors to the tests in a
structured way, allowing end-to-end tests on the config parsing and
validation system.

Closes #11 (improve validation)
Issue #22 (improve docs)

Change-Id: I44d24b2f8828c09600275c1df667abaabe242404
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 10, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Development

No branches or pull requests

2 participants