Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for direct HTTP URLs (not cloud storage) #210

Closed
joeyparrish opened this issue Nov 11, 2024 · 4 comments · Fixed by #212 or #209
Closed

Add support for direct HTTP URLs (not cloud storage) #210

joeyparrish opened this issue Nov 11, 2024 · 4 comments · Fixed by #212 or #209
Assignees
@joeyparrish
Labels
component: cloud upload An issue with cloud upload support priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
Backlog

Comments

@joeyparrish
Copy link
Member

v1.0.0 removed support for direct HTTP output (not cloud storage), to simplify the cloud storage rewrite. We should add it back.

@jspizziri, please let us know what your requirements are:

  1. Do you need support for configurable HTTP headers?
  2. Do you need support for any higher level auth tokens?
  3. Do you need anything else other than HTTP URLs for output being passed to Packager?
@joeyparrish joeyparrish added type: enhancement New feature or request component: cloud upload An issue with cloud upload support labels Nov 11, 2024
@joeyparrish joeyparrish mentioned this issue Nov 11, 2024
Merged
@github-actions github-actions bot added this to the Backlog milestone Nov 11, 2024
@jspizziri
Copy link

@joeyparrish thanks for your attention to this, really appreciate it!

  1. Do you need support for configurable HTTP headers?

We currently do not, but it could be nice. Not required though. We built it such that a signature is part of the base path rather than in a header.

  1. Do you need support for any higher level auth tokens?

No, not currently.

  1. Do you need anything else other than HTTP URLs for output being passed to Packager?

No, not currently. We were using it in a pretty vanilla way, where we'd pass a base URL with a signature of sorts as part of the path and then all the chunks get appended to that signed path.

@joeyparrish
Copy link
Member Author

Okay, then I'll add something that just allows plain HTTP URLs to be passed to Shaka Packager for output, without ProxyNode or any cloud storage clients.

joeyparrish added a commit to joeyparrish/shaka-streamer that referenced this issue Nov 11, 2024
@joeyparrish
feat: Restore HTTP output (not cloud storage)
f83b067 
 - Restore HTTP output
 - Deprecate -c for cloud storage URLs in favor of -o for output
 - Consolidate cloud storage docs
 - Reference cloud storage docs in command line help

Closes shaka-project#210
@joeyparrish joeyparrish mentioned this issue Nov 11, 2024
Merged
@joeyparrish joeyparrish self-assigned this Nov 11, 2024
@joeyparrish joeyparrish added the priority: P1 Big impact or workaround impractical; resolve before feature release label Nov 11, 2024
@shaka-bot shaka-bot mentioned this issue Nov 11, 2024
Merged
@matt5stones
Copy link

@joeyparrish Thanks for the update; this is working for our use case now!

@joeyparrish
Copy link
Member Author

Glad to hear it, @matt5stones!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 11, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: cloud upload An issue with cloud upload support priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
Backlog
3 participants
@jspizziri @joeyparrish @matt5stones