Skip to content

Commit

Permalink
fix: Fix minimum required version of Packager
Browse files Browse the repository at this point in the history
The change "Restrict WebM formats to DASH protocol (#80)" uses a
Packager feature that was introduced in Packager v2.5, but failed to
update the minimum required version in streamer/controller_node.py.

This change updates the minimum version to v2.5.

Issue #18

Change-Id: I894f72d979d6f3f5d88170a5ce62c113a5635f76
  • Loading branch information
joeyparrish committed Aug 26, 2021
1 parent ea9f1f2 commit 3cb7cc6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- Add `--skip_deps_check` to bypass version checks on dependencies
- Increase preserved segments outside of the availability window, improving HLS
playback in Shaka Player
- Require Shaka Packager v2.4+
- Require Shaka Packager v2.5+
- Add AV1 support
(https://github.com/google/shaka-streamer/issues/10)
- Drop `raw_images` input type
Expand Down
2 changes: 1 addition & 1 deletion streamer/controller_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def start(self, output_location: str,
_check_version('ffprobe', ['ffprobe', '-version'], (4, 1))

# Check that Shaka Packager version is 2.4.2 or above.
_check_version('Shaka Packager', ['packager', '-version'], (2, 4, 2))
_check_version('Shaka Packager', ['packager', '-version'], (2, 5, 1))

if bucket_url:
# Check that the Google Cloud SDK is at least v212, which introduced
Expand Down

0 comments on commit 3cb7cc6

Please sign in to comment.