Skip to content

Commit

Permalink
Require Shaka Packager v2.4
Browse files Browse the repository at this point in the history
This new release of Shaka Packager adds quiet mode and fixes some
issues reading MP4 from a named pipe.  This will enable work on AV1
support in Streamer.

Issue #10

Change-Id: I9675960f93bbe100740d26ba35cc62a712a3d239
  • Loading branch information
joeyparrish committed Jan 21, 2020
1 parent 2072d65 commit 11aa20b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Add `--skip_deps_check` to bypass version checks on dependencies
- Increase preserved segments outside of the availability window, improving HLS
playback in Shaka Player
- Require Shaka Packager v2.4+


## 0.3.0 (2019-10-18)
Expand Down
4 changes: 2 additions & 2 deletions streamer/controller_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def start(self, output_dir: str,
# above.
_check_version('ffprobe', ['ffprobe', '-version'], (4, 1))

# Check that Shaka Packager version is 2.1 or above.
_check_version('Shaka Packager', ['packager', '-version'], (2, 1))
# Check that Shaka Packager version is 2.4 or above.
_check_version('Shaka Packager', ['packager', '-version'], (2, 4))

if bucket_url:
# Check that the Google Cloud SDK is at least v212, which introduced
Expand Down
7 changes: 6 additions & 1 deletion streamer/packager_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ def start(self) -> None:

args += [self._setup_stream(stream) for stream in self._output_streams]

if self._pipeline_config.quiet:
args += [
'--quiet', # Only output error logs
]

args += [
# Segment duration given in seconds.
'--segment_duration', str(self._pipeline_config.segment_size),
Expand Down Expand Up @@ -146,7 +151,7 @@ def _setup_manifest_format(self) -> List[str]:
if ManifestFormat.DASH in self._pipeline_config.manifest_format: #type: ignore
if self._pipeline_config.streaming_mode == StreamingMode.VOD:
args += [
'--generate_static_mpd',
'--generate_static_live_mpd',
]
args += [
# Generate DASH manifest file.
Expand Down

0 comments on commit 11aa20b

Please sign in to comment.