Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v4.9.2-caf): release 4.9.3-caf2 #7750

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
".": "4.9.2-caf2"
".": "4.9.3-caf2"
}
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# Changelog

## [4.9.3-caf2](https://github.com/shaka-project/shaka-player/compare/v4.9.2-caf2...v4.9.3-caf2) (2024-12-11)


### Bug Fixes

* **Cast:** Incorrect detection of MediaCapabilities on Linux Chromecast ([#7628](https://github.com/shaka-project/shaka-player/issues/7628)) ([86fa9f1](https://github.com/shaka-project/shaka-player/commit/86fa9f1e4dcea57cf57f69495380b85f353386ea))
* Disable seek retry cooldown on most platforms ([#7010](https://github.com/shaka-project/shaka-player/issues/7010)) ([f980ae9](https://github.com/shaka-project/shaka-player/commit/f980ae96646cf4bda9920328889534af285c504d))
* Fix cast support for HLG HDR ([#7632](https://github.com/shaka-project/shaka-player/issues/7632)) ([b1df345](https://github.com/shaka-project/shaka-player/commit/b1df345daef0380276b2e3363dd1ee2390b3cd84))
* **HLS:** Fix playback of raw AAC ([#7641](https://github.com/shaka-project/shaka-player/issues/7641)) ([1e3e65f](https://github.com/shaka-project/shaka-player/commit/1e3e65fc129393de0269844a48c1214cbd1da4e4))
* Seek delay for Cast Nest hub ([#7423](https://github.com/shaka-project/shaka-player/issues/7423)) ([3adfd8f](https://github.com/shaka-project/shaka-player/commit/3adfd8f5b47c15ab76f7ca447f562e8325beaa33))


### Performance Improvements

* Reduce calls to isTypeSupported ([#7729](https://github.com/shaka-project/shaka-player/issues/7729)) ([2c0b36f](https://github.com/shaka-project/shaka-player/commit/2c0b36fe2112359fc67e214a74a3e64d0c9eb031))

## [4.9.2-caf2](https://github.com/shaka-project/shaka-player/compare/v4.9.2-caf1...v4.9.2-caf2) (2024-09-26)


Expand Down
2 changes: 1 addition & 1 deletion lib/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -7456,7 +7456,7 @@ shaka.Player.TYPICAL_BUFFERING_THRESHOLD_ = 0.5;
* @export
*/
// eslint-disable-next-line no-useless-concat, max-len
shaka.Player.version = 'v4.9.2-caf2' + '-uncompiled'; // x-release-please-version
shaka.Player.version = 'v4.9.3-caf2' + '-uncompiled'; // x-release-please-version

// Initialize the deprecation system using the version string we just set
// on the player.
Expand Down
64 changes: 36 additions & 28 deletions lib/util/stream_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,23 @@ shaka.util.StreamUtils = class {
* @private
*/
static checkVariantSupported_(variant, keySystem) {
const variantSupported = variant.decodingInfos.some((decodingInfo) => {
if (!decodingInfo.supported) {
return false;
}
if (keySystem) {
const keySystemAccess = decodingInfo.keySystemAccess;
if (keySystemAccess) {
if (keySystemAccess.keySystem != keySystem) {
return false;
}
}
}
return true;
});
if (!variantSupported) {
return false;
}
const ContentType = shaka.util.ManifestParserUtils.ContentType;
const Capabilities = shaka.media.Capabilities;
const ManifestParserUtils = shaka.util.ManifestParserUtils;
Expand Down Expand Up @@ -453,15 +470,17 @@ shaka.util.StreamUtils = class {
videoCodecs = [videoCodecs, audioCodecs].join(',');
}

const fullType = MimeUtils.getFullOrConvertedType(
video.mimeType, videoCodecs, ContentType.VIDEO);
if (video.codecs != videoCodecs) {
const fullType = MimeUtils.getFullOrConvertedType(
video.mimeType, videoCodecs, ContentType.VIDEO);

if (!Capabilities.isTypeSupported(fullType)) {
return false;
}
if (!Capabilities.isTypeSupported(fullType)) {
return false;
}

// Update the codec string with the (possibly) converted codecs.
video.codecs = videoCodecs;
// Update the codec string with the (possibly) converted codecs.
video.codecs = videoCodecs;
}
}

const audio = variant.audio;
Expand All @@ -478,31 +497,20 @@ shaka.util.StreamUtils = class {
if (audio) {
const codecs = StreamUtils.getCorrectAudioCodecs(
audio.codecs, audio.mimeType);
const fullType = MimeUtils.getFullOrConvertedType(
audio.mimeType, codecs, ContentType.AUDIO);
if (audio.codecs != codecs) {
const fullType = MimeUtils.getFullOrConvertedType(
audio.mimeType, codecs, ContentType.AUDIO);

if (!Capabilities.isTypeSupported(fullType)) {
return false;
}
if (!Capabilities.isTypeSupported(fullType)) {
return false;
}

// Update the codec string with the (possibly) converted codecs.
audio.codecs = codecs;
// Update the codec string with the (possibly) converted codecs.
audio.codecs = codecs;
}
}

return variant.decodingInfos.some((decodingInfo) => {
if (!decodingInfo.supported) {
return false;
}
if (keySystem) {
const keySystemAccess = decodingInfo.keySystemAccess;
if (keySystemAccess) {
if (keySystemAccess.keySystem != keySystem) {
return false;
}
}
}
return true;
});
return true;
}


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "shaka-player",
"description": "DASH/EME video player library",
"version": "4.9.2-caf2",
"version": "4.9.3-caf2",
"homepage": "https://github.com/shaka-project/shaka-player",
"author": "Google",
"maintainers": [
Expand Down
2 changes: 2 additions & 0 deletions test/player_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -3487,6 +3487,8 @@ describe('Player', () => {
stream.mimeType = 'video';
stream.codecs = 'unsupported';
stream.addDrmInfo('foo.bar');
stream.fullMimeTypes = new Set([shaka.util.MimeUtils.getFullType(
stream.mimeType, stream.codecs)]);
});
});
manifest.addVariant(1, (variant) => {
Expand Down
Loading