Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Avoid adding custom interstitials without URI #7696

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(Ads): Avoid adding custom interstitials without URI #7696

merged 1 commit into from
Nov 29, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 29, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Nov 29, 2024
@avelad avelad added this to the v4.13 milestone Nov 29, 2024
@avelad avelad merged commit 743b451 into shaka-project:main Nov 29, 2024
21 of 22 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 29, 2024
Open
@avelad avelad deleted the interstitial-missing-url branch November 29, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @tykus160