Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HLS): Make dummy streams for tags representing muxed audio #7343

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat(HLS): Make dummy streams for tags representing muxed audio #7343

merged 2 commits into from
Sep 20, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 19, 2024

Close #5836

@avelad
Copy link
Member Author

avelad commented Sep 19, 2024

Stream to test it: https://ztnr.rtve.es/ztnr/1694255.m3u8

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking labels Sep 19, 2024
@avelad avelad added this to the v4.12 milestone Sep 19, 2024
@avelad avelad force-pushed the hls-pick-up-audio-from-video branch from d3a5c12 to c44eef4 Compare September 19, 2024 14:26
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 67.82%

joeyparrish
joeyparrish reviewed Sep 19, 2024
View reviewed changes
roadmap.md Outdated Show resolved Hide resolved
theodab
theodab reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I'm understanding correctly, this change is making it so that now, we will now make a dummy stream with an empty segment index when we see an audio tag that represents audio that has been muxed into a video stream, correct?

If that's right, I would suggest a title like:

feat(HLS): Make dummy streams for tags representing muxed audio

@avelad avelad changed the title feat(HLS): Pick up an audio track from the original video feat(HLS): Make dummy streams for tags representing muxed audio Sep 20, 2024
@avelad avelad requested a review from joeyparrish September 20, 2024 09:23
@avelad
Copy link
Member Author

avelad commented Sep 20, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7343

@avelad avelad merged commit e2413ed into shaka-project:main Sep 20, 2024
30 of 31 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 20, 2024
Merged
@avelad avelad deleted the hls-pick-up-audio-from-video branch September 23, 2024 05:23
@avelad avelad mentioned this pull request Sep 23, 2024
Merged
avelad added a commit that referenced this pull request Sep 23, 2024
@avelad
fix(HLS): Avoid disabling muxed audio streams (#7351)
53cea44 
Related to #7343
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.

[HLS] Player is not able to pick up an audio track from the original video
4 participants
@avelad @shaka-bot @joeyparrish @theodab