Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix resolution label when the stream has not resolution #7043

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(UI): Fix resolution label when the stream has not resolution #7043

merged 1 commit into from
Jul 16, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jul 15, 2024

No description provided.

@avelad
Copy link
Member Author

avelad commented Jul 15, 2024

This can happen with the following playlist from Google DAI.

#EXTM3U

#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=596000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/e1b32ab8c1fb5585ab9f078b6591f3c7/bandwidth/596000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=4628000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/fbdc5496b6237250a128496e3056ba2c/bandwidth/4628000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1428000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/dc909c14caa56d18b92d52133d40c926/bandwidth/1428000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=2628000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/a9b66e1be6c0fc1104c71b10b421e3a2/bandwidth/2628000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=257000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/86d5aa06cf2738dc5a9e270f4fe23ac5/bandwidth/257000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=332000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/c79c8869575c45e41f44323d2132072e/bandwidth/332000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1928000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/543eb7feae54aa3ed0ca7db3c0310797/bandwidth/1928000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=896000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/517a6bab0b784d7a5adc3584a9a85c23/bandwidth/896000.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=3528000
https://dai.google.com/linear/hls/pa/event/c-rArva4ShKVIAkNfy6HUQ/stream/602679ba-73ee-4de1-a63e-0767817122a8:BRU/variant/ac5fa01db25f3a38734aaf30f8264d20/bandwidth/3528000.m3u8

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release labels Jul 15, 2024
@avelad avelad added this to the v4.11 milestone Jul 15, 2024
@avelad avelad requested a review from theodab July 15, 2024 14:11
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 089518c into shaka-project:main Jul 16, 2024
12 of 19 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 16, 2024
Merged
@avelad avelad deleted the ui-resolution-selection branch July 16, 2024 06:26
avelad added a commit that referenced this pull request Jul 18, 2024
@avelad
fix(UI): Fix resolution label when the stream has not resolution (#7043)
7f7f6f1
@shaka-bot shaka-bot mentioned this pull request Jul 18, 2024
Merged
avelad added a commit that referenced this pull request Jul 18, 2024
@avelad
fix(UI): Fix resolution label when the stream has not resolution (#7043)
9e468f4
@shaka-bot shaka-bot mentioned this pull request Jul 18, 2024
Merged
avelad pushed a commit that referenced this pull request Jul 18, 2024
@shaka-bot
chore(v4.10.x): release 4.10.7 (#7063)
fafc626 
🤖 I have created a release *beep* *boop*
---


##
[4.10.7](v4.10.6...v4.10.7)
(2024-07-18)


### Bug Fixes

* Allow reference mimeType change in StreamingEngine
([#7061](#7061))
([2fe4dcc](2fe4dcc))
* **DASH:** Prioritize highest bandwidth in PeriodCombiner
([#7045](#7045))
([30cdd61](30cdd61))
* Destroy correctly unused transmuxer
([#7059](#7059))
([7641475](7641475))
* Fix MSE polyfill for iOS
([#7049](#7049))
([44dc9a9](44dc9a9))
* **HLS:** Remove init segment on formats without init segment
([#7060](#7060))
([ee179ad](ee179ad))
* **Transmuxer:** Fix init segment between discontinuities
([#7042](#7042))
([dd2a6d7](dd2a6d7))
* **ttml:** Handle escaped special characters.
([#7047](#7047))
([451a41e](451a41e)),
closes
[#7044](#7044)
* **UI:** Fix resolution label when the stream has not resolution
([#7043](#7043))
([9e468f4](9e468f4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 14, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @theodab