fix: Disable seek retry cooldown on most platforms #7010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek. This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation. However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices. Issue shaka-project#4393
|
Based on some practical testing I did, it seems like v2 Chromecasts are probably safe from this issue? |
|
Incremental code coverage: 65.62% |
avelad
added
the
priority: P1
avelad
reviewed
Jul 9, 2024
| static isSeekingSlow() { | ||
| const Platform = shaka.util.Platform; | ||
| if (Platform.isChromecast()) { | ||
| if (Platform.isAndroidCastDevice()) { |
There was a problem hiding this comment.
For reference...
I didn't have a Fuchsia device to test with, so I can't say for sure it's not a problem in them. It's probably fine, I was just being purposefully conservative with this change.
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
avelad
approved these changes
Jul 9, 2024
avelad
added a commit
that referenced
this pull request
Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek. This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation. However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices. Fixes #4393 Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
avelad
added a commit
that referenced
this pull request
Jul 10, 2024
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek. This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation. However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices. Fixes #4393 Fixes #5202 --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added a 1 second "cooldown" period between attempts to perform a corrective seek.
This was for the benefit of old v1 Chromecasts, which found the process of seeking so slow that they would sometimes get stuck in an infinite loop trying to start a presentation.
However, that cooldown period was causing issues in some situations during seeking, so this PR removes the restriction on everything but pre-Android Chromecast devices.
Fixes #4393
Fixes #5202