Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add audio codec to selectAudioLanguage() #6723

Merged
merged 7 commits into from
Jun 7, 2024
Merged

feat: Add audio codec to selectAudioLanguage() #6723

merged 7 commits into from
Jun 7, 2024

Conversation

tykus160
Copy link
Member

  • adds optional argument to selectAudioLanguage() which gives us a way to select preferred audio codec
  • updates PreferenceBasedCriteria to reflect the change
  • renders codec in shaka UI to help distinguish tracks with the same language, role, channels, etc
  • can be tested on Chrome with Tears of Steel (multicodec, TTML) asset

avelad
avelad reviewed May 31, 2024
View reviewed changes
avelad
avelad reviewed May 31, 2024
View reviewed changes
@avelad avelad requested review from joeyparrish May 31, 2024 14:22
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels May 31, 2024
@avelad avelad modified the milestone: v4.10 May 31, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 31, 2024 •
edited
Loading

Incremental code coverage: 73.17%

@tykus160 tykus160 requested a review from avelad June 5, 2024 06:21
@avelad avelad merged commit 48bdf17 into shaka-project:main Jun 7, 2024
14 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Jun 7, 2024
Merged
@tykus160 tykus160 deleted the wt-preferred-audio-codec branch June 7, 2024 15:40
@absidue absidue mentioned this pull request Jul 12, 2024
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 6, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
3 participants
@tykus160 @shaka-bot @avelad