Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix deprecation warning for manifestPreprocessor that is always logged #6496

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Apr 29, 2024

Fixes #6488

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Apr 29, 2024
@avelad avelad added this to the v4.9 milestone Apr 29, 2024
@avelad avelad merged commit 0873d1e into shaka-project:main Apr 29, 2024
14 of 17 checks passed
@avelad avelad deleted the bad-alwaysWarn branch April 29, 2024 10:41
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 82.35%

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning for manifest.dash.manifestPreprocessor is always logged
3 participants