fix: AC-3 audio codec support on Tizen #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
requested changes
Jan 26, 2024
avelad
added
type: bug
Boubalou
force-pushed
the
fix/tizen-ac-3
branch
from
ed4dabc to
bb367cc
Compare
avelad
approved these changes
Jan 26, 2024
avelad
pushed a commit
that referenced
this pull request
Jan 30, 2024
avelad
pushed a commit
that referenced
this pull request
Jan 30, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description of the problem
A regression got introduced in version
4.2.7where audio.codecs got rewrite (ref: #4858) with the corrected audio codecs.After this change, the player tries to play the audio stream with codec EC-3 instead of AC-3 (the original value provided by the manifest representation) due to the current implementation of supporting AC-3 on Tizen.
📚 Fix
Delegating the check from ac-3 to ec-3 in
stream_utilsto the actual media capabilities polyfill so that when a system is requesting the support ofAC-3audio codec on Tizen, we change the capabilities toEC-3and let it do its check.📓 Reference
This completes the work on 🐛 #6160.
🗒 Note
It was tested locally on a real Samsung TV (Tizen 5.0) in our internal project using Shaka as well as a dumbed down project with Shaka only providing the manifest listed in the bug.