Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Demo): Allow configure some missing configs #5918

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix(Demo): Allow configure some missing configs #5918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions demo/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ shakaDemo.Config = class {
'manifest.hls.ignoreImageStreamFailures')
.addTextInput_('Default Audio Codec', 'manifest.hls.defaultAudioCodec')
.addTextInput_('Default Video Codec', 'manifest.hls.defaultVideoCodec')
.addTextInput_('Default media playlist full mime type',
'manifest.hls.mediaPlaylistFullMimeType')
.addBoolInput_('Ignore Program Date Time from manifest',
'manifest.hls.ignoreManifestProgramDateTime')
.addBoolInput_('Use Safari behavior for live',
Expand Down Expand Up @@ -415,6 +417,8 @@ shakaDemo.Config = class {
'streaming.observeQualityChanges')
.addNumberInput_('Max Variant Disabled Time',
'streaming.maxDisabledTime')
.addBoolInput_('Parse PRFT box',
'streaming.parsePrftBox')
.addNumberInput_('Segment Prefetch Limit',
'streaming.segmentPrefetchLimit')
.addBoolInput_('Live Sync', 'streaming.liveSync')
Expand Down Expand Up @@ -524,6 +528,7 @@ shakaDemo.Config = class {
this.addSection_('Language', docLink)
.addTextInput_('Preferred Audio Language', 'preferredAudioLanguage')
.addTextInput_('Preferred Audio Label', 'preferredAudioLabel')
.addTextInput_('Preferred Variant Role', 'preferredVariantRole')
.addTextInput_('Preferred Text Language', 'preferredTextLanguage')
.addTextInput_('Preferred Text Role', 'preferredTextRole')
.addSelectInput_('Auto-Show Text',
Expand Down
3 changes: 0 additions & 3 deletions test/demo/demo_unit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,11 @@ describe('Demo', () => {
function checkConfig(checkValueNameFn) {
const configPrimitives = new Set(['number', 'string', 'boolean']);
const exceptions = new Set()
.add('preferredVariantRole')
.add('playRangeStart')
.add('playRangeEnd')
.add('manifest.dash.keySystemsByURI')
.add('manifest.hls.mediaPlaylistFullMimeType')
.add('manifest.mss.keySystemsBySystemId')
.add('drm.keySystemsMapping')
.add('streaming.parsePrftBox')
.add('manifest.raiseFatalErrorOnManifestUpdateRequestFailure')
.add('drm.persistentSessionOnlinePlayback')
.add('drm.persistentSessionsMetadata');
Expand Down