Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add config to preferDocumentPictureInPicture #5690

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 28, 2023

Closes #5689

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Sep 28, 2023
@avelad avelad added this to the v4.5 milestone Sep 28, 2023
@beaufortfrancois
Copy link
Contributor

LGTM

@avelad
Copy link
Member Author

avelad commented Sep 28, 2023

@beaufortfrancois can you review the focus issues reported on #5689 (comment) ? Thanks!

@avelad avelad merged commit 025502a into shaka-project:main Sep 28, 2023
@avelad avelad deleted the ui-prefer-document-pip branch September 28, 2023 09:31
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 71.43%

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 27, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to switch between Document Picture-In-Picture and Picture-In-Picture mode?
4 participants