Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent codecs override in the transmuxer #5568

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 31, 2023

This prevent errors when the codec specified is not the same that in the stream, and also fixes the override when there are multiples codecs (eg: muxed content)

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Aug 31, 2023
@avelad avelad added this to the v4.5 milestone Aug 31, 2023
@avelad avelad requested review from theodab and joeyparrish August 31, 2023 08:34
@github-actions
Copy link
Contributor

Incremental code coverage: 50.00%

@avelad avelad merged commit 66c625f into shaka-project:main Aug 31, 2023
@avelad avelad deleted the codec-override branch August 31, 2023 09:19
joeyparrish pushed a commit that referenced this pull request Sep 2, 2023
This prevent errors when the codec specified is not the same that in the
stream, and also fixes the override when there are multiples codecs (eg:
muxed content)
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 30, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants