ci: Talk to Shaka Bot #5565
ci: Talk to Shaka Bot #5565
Conversation
Now maintainers can send commands to Shaka Bot via PR comments. Shaka Bot understands the following commands to start: - `@shaka-bot help`: Show this help message - `@shaka-bot test`: Start lab tests (maintainers only)
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
With this, instead of copying the PR number, clicking "Actions", finding "Selenium lab tests", clicking that, then clicking the "Run workflow" button, then pasting in the PR number, then clicking yet another "Run workflow button"... I could just comment on the PR with |
|
Incremental code coverage: No instrumented code was changed. |
Great feature. Will it be documented somewhere? How could I discover this ability of the Shaka bot? |
Good question. I'm not sure. We can add it to the maintenance documentation for the project: https://github.com/shaka-project/shaka-project.github.io/blob/main/maintenance/shaka-player.md But I was wondering if I should add a feature to have the bot comment on each new PR to remind maintainers of common tasks it can do. Maybe I should document it first, then try out some kind of reminder feature later. Thoughts? |
|
I'm about to do a test run of the refactored bash script against this PR. I'm supplying all the values manually and running it locally with shaka-bot's token. When shaka-bot starts commenting on this PR, that's the result of my manual testing. |
|
@joeyparrish: I understand the following commands:
|
|
@joeyparrish: Only maintainers may start lab tests. |
1 similar comment
|
@joeyparrish: Only maintainers may start lab tests. |
|
@joeyparrish: Lab tests started. |
|
@alekzz, I think you'll find the refactored version much improved. Let me know what you think! |
|
@joeyparrish: I honor the following commands from anyone:
I honor the following commands from maintainers only:
|
|
@joeyparrish: Lab tests started with arguments: pr=5565 browser_filter=Tizen Chromecast ChromeAndroid |
|
@joeyparrish: Lab tests started with arguments:
|
Done!
|
Adding to the maintenance documentation sounds reasonable and sufficient IMHO. |
Yes, looks very good! Thanks! |
| @@ -0,0 +1,27 @@ | |||
| # Copyright 2022 Google LLC | |||
There was a problem hiding this comment.
It's a copy-paste bug.
Now maintainers can send commands to Shaka Bot via PR comments. Initially, Shaka Bot understands the following commands from anyone: - `@shaka-bot help`: Show this help message And the following commands from maintainers only: - `@shaka-bot test`: Start lab tests on all devices - `@shaka-bot test ce`: Start lab tests on CE devices only (no desktop browsers)
Now maintainers can send commands to Shaka Bot via PR comments. Initially, Shaka Bot understands the following commands from anyone: - `@shaka-bot help`: Show this help message And the following commands from maintainers only: - `@shaka-bot test`: Start lab tests on all devices - `@shaka-bot test ce`: Start lab tests on CE devices only (no desktop browsers)
Now maintainers can send commands to Shaka Bot via PR comments.
Initially, Shaka Bot understands the following commands from anyone:
@shaka-bot help: Show this help messageAnd the following commands from maintainers only:
@shaka-bot test: Start lab tests on all devices@shaka-bot test ce: Start lab tests on CE devices only (no desktop browsers)