-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Orange set top box is incorrectly categorized as Apple #5545
Merged
joeyparrish
merged 47 commits into
shaka-project:main
from
cbsinteractive:fix/orange-platform
Aug 28, 2023
Merged
fix: Orange set top box is incorrectly categorized as Apple #5545
joeyparrish
merged 47 commits into
shaka-project:main
from
cbsinteractive:fix/orange-platform
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…culations" This reverts commit 127b183.
Add Orange platform and exclude from isApple platform test.
avelad
added
type: bug
Something isn't working correctly
platform: TV/STB
Issues affecting smart TV or set-top box platforms
priority: P2
Smaller impact or easy workaround
labels
Aug 28, 2023
avelad
approved these changes
Aug 28, 2023
joeyparrish
approved these changes
Aug 28, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Aug 30, 2023
This PR adds an Orange platform check and excludes Orange from the isApple() check. Resolves: #5544 --------- Co-authored-by: Dan Sparacio <[email protected]> Co-authored-by: Casey Occhialini <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Aug 30, 2023
This PR adds an Orange platform check and excludes Orange from the isApple() check. Resolves: #5544 --------- Co-authored-by: Dan Sparacio <[email protected]> Co-authored-by: Casey Occhialini <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
platform: TV/STB
Issues affecting smart TV or set-top box platforms
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Orange platform check and excludes Orange from the isApple() check.
Resolves: #5544