Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Initialize correctly the IMA ads manager #5541

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix(Ads): Initialize correctly the IMA ads manager #5541

merged 1 commit into from
Aug 28, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 28, 2023

Fixes #4800

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Aug 28, 2023
@avelad avelad added this to the v4.4 milestone Aug 28, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@joeyparrish joeyparrish merged commit 4428adf into shaka-project:main Aug 28, 2023
@avelad avelad deleted the cc-vmap-load branch August 29, 2023 06:45
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
@avelad @joeyparrish
fix(Ads): Initialize correctly the IMA ads manager (#5541)
f15ba16 
Fixes #4800

Backported to v4.3.x
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
@avelad @joeyparrish
fix(Ads): Initialize correctly the IMA ads manager (#5541)
fa82928 
Fixes #4800

Backported to v4.3.x
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 27, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Preroll fails with VMAP, if autoplay is disabled
3 participants
@avelad @joeyparrish @shaka-bot