Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix Chrome failures on Mac VMs #5509

Merged
merged 1 commit into from
Aug 19, 2023
Merged

ci: Fix Chrome failures on Mac VMs #5509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,14 @@ jobs:
# Install a launcher that can execute a shell script to launch this
npm install karma-script-launcher --save-dev

# When "Chrome for Testing" is installed on Mac, it gets invoked instead
# of simply "Chrome". This other copy of Chrome, however, doesn't seem
# to have basic codecs like AAC and H264 available, causing many of our
# test scenarios to fail. Deleting "Chrome for Testing" fixes this.
- name: 'Delete "Chrome for Testing" on Mac'
if: matrix.os == 'macos-latest' && matrix.browser == 'Chrome'
run: sudo rm -rf /Applications/Google\ Chrome\ for\ Testing.app

# Some CI images (self-hosted or otherwise) don't have the minimum Java
# version necessary for the compiler (Java 11).
- uses: actions/setup-java@v3
Expand Down