Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Add thumbnails to the UI #5502

Merged
merged 10 commits into from
Aug 22, 2023
Merged

feat(UI): Add thumbnails to the UI #5502

merged 10 commits into from
Aug 22, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 18, 2023 •
edited
Loading

Closes #3371

Stored content thumbnails are not supported.

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Aug 18, 2023
@avelad avelad added this to the v4.4 milestone Aug 18, 2023
@avelad avelad mentioned this pull request Aug 18, 2023
Closed
@francoism90
Copy link
Contributor

@avelad Do you have a screenshot? And how does it work? :)

@avelad
Copy link
Member Author

avelad commented Aug 18, 2023

Grabacion.de.pantalla.2023-08-18.a.las.16.34.56.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023 •
edited
Loading

Incremental code coverage: No instrumented code was changed.

theodab
theodab requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in motion and I didn't notice any bugs during testing.
There are some structural simplifications I think you could make though.

ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab August 22, 2023 09:49
theodab
theodab requested changes Aug 22, 2023
View reviewed changes
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
ui/seek_bar.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab August 22, 2023 10:36
@avelad avelad merged commit c483975 into shaka-project:main Aug 22, 2023
@avelad avelad deleted the thumbnails-ui branch August 22, 2023 12:28
@absidue absidue mentioned this pull request Oct 17, 2023
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 21, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Add thumbnails to the UI
4 participants
@avelad @francoism90 @theodab @shaka-bot