Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SRT): Support stylized payload in SRT format #5500

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 18, 2023

Info about the format in https://docs.fileformat.com/video/srt/

@avelad avelad added type: enhancement New feature or request component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking labels Aug 18, 2023
@avelad avelad added this to the v4.4 milestone Aug 18, 2023
@avelad avelad changed the title feat: Support stylized payload in SRT format feat(SRT): Support stylized payload in SRT format Aug 18, 2023
@avelad avelad requested review from littlespex and theodab August 18, 2023 12:59
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad requested a review from theodab August 19, 2023 08:39
@avelad avelad merged commit 963cf61 into shaka-project:main Aug 21, 2023
@avelad avelad deleted the srt-stylized branch August 21, 2023 12:28
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 20, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants